Well, from the post it's not really clear to me what you added in this update, and the commit messages don't tell me much either. Would be great if you explain what you added for future posts, as it seems the majority of the post is just general information that is included in all your posts.
As for the code:
- There is some duplication, like
isMobile()being defined twice. - Should use
constas well aslet, not justlet. - No comments at all, which makes it, in conjunction with the added features not being explained here, pretty difficult to quickly grasp what is going on.
- Lot of commented-out code and minor inconsistencies. I recommend you use a linter to make your code more clean.
I tried reviewing it as fair as possible, but with my lack of understanding what you actually added, because of the lack of information in the post, some answers might be inaccurate. I'd recommend you try to make it abundantly clear what features have been added in your future posts, so it's easier for us, and other people reading your posts, to understand what you added.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
RE: MyDiceBot - Android Edition is on Google Play NOW!