Although we normally like people to keep the commits / pull requests to < 14 days old, we try to be lenient with it. Considering the immense amount of work and features added, I've decided to completely forgo that - great stuff man! Some of these features are really incredible, and I wish I could implement stuff like this myself, haha. Just so you know, I've decided to staff pick this, so it will receive the maximum score possible!
Even so, I'd like to give some feedback:
- I saw another guy with the same weird indentation in PHP as you yesterday, so maybe I am the weird one ;)
- The JavaScript code is sort of stuck in the past. Nowadays you can use ES6 syntax and let Babel / Webpack compile everything for you. Inb4 it's more optimised this way ;)
I am really impressed by this contribution, it has sort of blown me away. In the future you could even submit this in smaller parts if you want to, but I guess you wanted to complete it before doing so. Anyway, looking forward to seeing what else you guys submit, as it's always very cool stuff!
Need help? Chat with us on Discord.
RE: Frontend Users - New Sign up + new Log in + Site types