Welcome back! It's cool to see you guys are still actively working on this, as I remember seeing some posts about this project before. Here is some feedback:
- In the comparison there are some commits > 14 days old - even if we are sort of lenient with this, try and keep it below.
- Some magic numbers like
16511and variables calledn2,n3etc. - could make into constants and make more descriptive respectively. - Could provide a description of what the function does instead of only having the arguments' names and types.
- Some funny indentation in the lists. Is lining up everything like this common in PHP?
Am interested to see what kind of features you guys add next. Any specific plans?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
RE: Update Of PHP Graphene Node Client [v5.1.2 - v5.2.0]