Abstract the definition of openstreetmap resources

Components

The components affect are all aspects of the system that deal with the map domain, the parsing, rendering and editing of map components.

The java code that deals with openstreetmap and allows to edit has hard coded constants that limit how the app can be used.

Proposal

The proposal is to strip out all the code that contains hard coded resources like "restaurant" and attributes like "Internet" and put them into a datafile the defines what the resources are , what attributes they support and how to render them. The app will then read that definition file in an be able to be extended for more types of data easily. The duplication of code will be reduced.

Code Review

The java code has a lot of copy and past of string tags that could be consolidated like this.

The list of tags to support does not need to be in the java code and can be read from a property file in this location https://github.com/CityZenApp/Android-Development/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/ApplicationConstants.java

There are switches based on the tags that would be better represented as property files like this one https://github.com/CityZenApp/Android-Development/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Adapters/ParcelablePoiListAdapter.java

this code is duplicated here leading to higher maintenance costs:
https://github.com/CityZenApp/Android-Development/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Adapters/PlaceListAdapter.java

This lookup can have internet could also be put into a resource file, or some other description of the types of data outside of the code.
https://github.com/CityZenApp/Android-Development/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Fragments/EditPoiFragment.java

It is also duplicated here:
https://github.com/CityZenApp/Android-Development/blob/master/CityZenApp/app/src/main/java/com/cityzen/cityzen/Fragments/CreatePoiFragment.java#L464

Mockups / Examples

See the website here http://visualtags.hotosm.org/collection/3 with the xml file give

  <group name="Food+Drinks" icon="presets/restaurant.png">
        <item name="Restaurant" icon="presets/restaurant.png" type="node,relation">
          <link href="http://wiki.openstreetmap.org/wiki/Tag:amenity=restaurant"/>
          <label text="Edit Restaurant"/>
          <key key="amenity" value="restaurant"/>
          <text key="name" text="Name"/>
          <space/>
          <text key="operator" text="Operator"/>
          <multiselect key="cuisine" text="Cuisine" values="italian;chinese;pizza;burger;greek;german;indian;regional;kebab;turkish;asian;thai;mexican;japanese;french;sandwich;sushi"/>
          <check key="microbrewery" text="Microbrewery" default="off"/>
          <text key="opening_hours" text="Opening Hours"/>
          <combo key="stars" text="Stars" values="1,2,3,4,5,6,7"/>
          <space/>
          <combo key="internet_access" text="Internet access" values="yes,wlan,wired,terminal,no"/>
          <space/>